Fix NTLM auth API missing logs #8448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds logging module modify default app logging format
satkunas
reviewed
Dec 31, 2024
JeGoi
reviewed
Jan 2, 2025
|
|
||
| if None in (c_db_host, c_db_port, c_db_user, c_db_pass, c_db, c_db_unix_socket): | ||
| print(f" DB config: Missing settings, NT Key cache will be disabled") | ||
| log.warning(f" DB config: Missing settings, NT Key cache will be disabled") |
There was a problem hiding this comment.
This one should be a log.error no?
It will not allow to enable the cache.
There was a problem hiding this comment.
similar to the previous one, cache disabled. but still works.
I don't think this is an error or critical scenario.
they will only see the message during ntlm auth api starts.
change several logging levels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix missing NTLM auth API logs
added several common error cases for easier troubleshooting.
Impacts
Issue
fixes #8414
Delete branch after merge
YES
Checklist
(REQUIRED) - [yes, no or n/a]
Enhancements
added more detailed logs of ntlm-auth-api
added several common NTErrors
Bug Fixes